Skip to content

Fixed - Text with adjustsFontSizeToFit changes the text layout infinitely #33135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alfonsocj wants to merge 1 commit into from
Closed

Fixed - Text with adjustsFontSizeToFit changes the text layout infinitely #33135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "Fixed dynamic behavior of <Text adjustsFontSizeToFit={true}> … 
…on Android (#31538)"

This reverts commit 5902152.
  • Loading branch information
@alfonsocj-cb
alfonsocj-cb committed Feb 17, 2022
commit a774c167a3ac1377acd3b055b2c4f38b314cc2e9
5 changes: 0 additions & 5 deletions ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,11 +343,6 @@ public void onCollectExtraUpdates(UIViewOperationQueue uiViewOperationQueue) {
mJustificationMode);
uiViewOperationQueue.enqueueUpdateExtraData(getReactTag(), reactTextUpdate);
}

if (mAdjustsFontSizeToFit) {
// Nodes with `adjustsFontSizeToFit` enabled need to be remeasured on every relayout.
markUpdated();
}
}

@ReactProp(name = "onTextLayout")
Expand Down