Deprecate [RCTConvert UIBarStyle:]#42100
Closed
Saadnajmi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
Author
|
@okwasniewski FYI |
facebook-github-bot
added
the
Shared with Meta
Contributor
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @Saadnajmi in 157cb0e. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
Summary: Resolves microsoft#2008 Followup to #42100 / 157cb0e , let's remove the deprecated RCTConvert method. ## Changelog: [IOS] [REMOVED] - Remove `[RCTConvert UIBarStyle:]` Pull Request resolved: #44597 Test Plan: CI should pass Reviewed By: christophpurrer Differential Revision: D59128144 Pulled By: javache fbshipit-source-id: 3e66422a7f4a139a6d68cbdfc6aae211ea239d4e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The enums UIBarStyleBlackOpaque and UIBarStyleBlackTranslucent have been deprecated since iOS 13, already below React Native's minimum OS of iOS 13.4. Indeed, they are not available on visionOS and tvOS, making this a source of extra diffs.
Rather than deprecate and remove those options, I noticed that we don't actually use that
RCTConvertmethod in the core repo, and haven't since0.58-stable(presumably before the lean core effort). Let's just remove it, it's a conversion that should be easy enough to replicate elsewhere. However, removal is a breaking change, so let's deprecate it for one release (0.74) and remove it for the next one (0.75). For posterity, tracking deprecation with microsoft#2008 and removal with microsoft#2009 .Changelog:
[IOS] [DEPRECATED] - Deprecate
[RCTConvert UIBarStyle:]Test Plan:
CI should pass