prevent fatal crashes when launching App Clips#47000
Closed
EvanBacon wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@lunaleaps merged this pull request in 043e2fe. |
Collaborator
|
This pull request was successfully merged by @EvanBacon in 043e2fe When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
App Clips are full of bugs. One such bug is how launching an App Clip from Test Flight (and perhaps other systems) will cause the user activity to be of type
NSUserActivityTypeBrowsingWebbut with a nullishuserActivity.webpageURL(even though it's typed as never being nullish in this mode).Changelog:
[IOS] [FIXED] - Fix launching App Clips with nullish URLs.
Test Plan:
The following was failing cryptically and required extensive debugging to get launching.
ScreenRecording_10-12-2024.20-37-41_1.mov