Remove redundant check in CSSRatio #48842
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68474836 |
NickGerleman
force-pushed
the
export-D68474836
branch
from
29679bb to
3d72a17
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68474836 |
…aOrWhitespaceOrSolidus (facebook#48828) Summary: 1. Rename `CSSComponentValueDelimeter` to `CSSDelimeter` bc the names are getting way too long. 2. Make the distinction between `Whitespace` and `OptionalWhitespace`. Note that for property values, and function blocks, the value parser will already remove trailing/leading whitespace, but it's weird that whitespace unlike others was not required to be present 3. Add `CSSDelimeter::CommaOrWhitespaceOrSolidus` for simpler parsing in the common pattern of alpha values, and move CSSColor function parsing to use that Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68461968
Summary: In the last diff I mixed and matched `<legacy-rgb-syntax>` and `<modern-rgb-syntax>` a bit to keep compatiblity with `normalze-color`. Spec noncompliant values have only been allowed since facebook#34600 with the main issue being that legacy syntax rgb functions are allowed to use the `/` based alpha syntax, and commas can be mixed with whitespace. This seems like an exceedingly rare real-world scenario (there are currently zero usages of slash syntax in RKJSModules validated by `rgb\([^\)]*/`), so I'm going to instead just follow the spec for more sanity. Another bit that I missed was that modern RGB functions allow individual components to be `<percentage>` or `<number>` compared to legacy functions which only allow the full function to accept one or the other (`normalize-color` doesn't support `<percentage>` at all), so I fixed that as well. I started sharing a little bit more of the logic here, to make things more readable when adding more functions. Changelog: [Internal] Reviewed By: javache Differential Revision: D68468275
…facebook#48841) Summary: Right now during parsing we can ask for a next component value, with a delimeter, and even if we don't have a component value to consume, we will consume the delimeter. This is kind of awkward since e.g. trailing comma can be consumed, then we think syntax is valid. Let's try changing this. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68474739
Summary: This is a result of inlining isinf previously but we can never be negative infinity because we can never be less than zero. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68474836
NickGerleman
force-pushed
the
export-D68474836
branch
2 times, most recently
from
223d397 to
1b5ad41
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68474836 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D68474836 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jan 23, 2025
Summary: This is a result of inlining isinf previously but we can never be negative infinity because we can never be less than zero. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68474836
Contributor
|
This pull request has been merged in 91add1e. |
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Pull Request resolved: facebook#48842 This is a result of inlining isinf previously but we can never be negative infinity because we can never be less than zero. Changelog: [Internal] Reviewed By: lenaic Differential Revision: D68474836 fbshipit-source-id: bfce78c4bd269ff2afac99c03250ede676ee1029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a result of inlining isinf previously but we can never be negative infinity because we can never be less than zero.
Changelog: [Internal]
Differential Revision: D68474836