Skip to content

Reland: [iOS] [Fabric] Fixes crash of dynamic color when light/dark mode changed #49265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhongwuzw wants to merge 8 commits into from
Closed

Reland: [iOS] [Fabric] Fixes crash of dynamic color when light/dark mode changed #49265

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
795e684
fix crash
zhongwuzw Nov 8, 2024
adeafa9
Merge commit 'b867c01fa624a3140ac1b8415b34b6db33fae1b4' into features…
zhongwuzw Jan 5, 2025
a720b3d
format
zhongwuzw Jan 5, 2025
8949170
pre-calculate the hash and store it as an associated object on the U…
zhongwuzw Jan 15, 2025
3e72b4d
update
zhongwuzw Jan 15, 2025
dad55b5
Apply review back
zhongwuzw Jan 21, 2025
fabf86f
Move category to HostPlatformColor
zhongwuzw Feb 3, 2025
6329f2e
Put hash value to constructor
zhongwuzw Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move category to HostPlatformColor
  • Loading branch information
@zhongwuzw
zhongwuzw committed Feb 3, 2025
commit fabf86f5b2e7106cf9acf423edef3cf60d421bfc
16 changes: 15 additions & 1 deletion ...tCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/HostPlatformColor.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
*/

#import "HostPlatformColor.h"
#import "UIColor+Graphics.h"

#import <Foundation/Foundation.h>
#import <UIKit/UIKit.h>
#import <objc/runtime.h>
#import <react/renderer/graphics/RCTPlatformColorUtils.h>
#import <react/utils/ManagedObjectWrapper.h>
#import <string>
Expand All @@ -18,6 +18,20 @@

NS_ASSUME_NONNULL_BEGIN

@implementation UIColor (React_Graphics)

- (int32_t)reactHash
{
return [objc_getAssociatedObject(self, _cmd) intValue];
}

- (void)setReactHash:(int32_t)reactHash
{
objc_setAssociatedObject(self, @selector(reactHash), @(reactHash), OBJC_ASSOCIATION_RETAIN_NONATOMIC);
}

@end

namespace facebook::react {

namespace {
Expand Down
18 changes: 0 additions & 18 deletions ...actCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/UIColor+Graphics.h
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions ...actCommon/react/renderer/graphics/platform/ios/react/renderer/graphics/UIColor+Graphics.m
View file
Open in desktop

This file was deleted.

Loading