Closed
Conversation
Contributor
|
By analyzing the blame information on this pull request, we identified @frantic, @longdivision and @oveddan to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
@frantic updated the pull request. |
Contributor
|
🚀 🚀 🚀 |
Contributor
|
@frantic updated the pull request. |
Contributor
Author
|
@facebook-github-bot shipit |
Contributor
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1556602384662406/int_phab to review. |
Before this commit the websocket proxy treated every connection the same way, which sometimes resulted in bugs like having 2 debuggers connected, etc. Now it allows only 1 debugger and 1 client.
Contributor
|
@frantic updated the pull request. |
ghost
closed this
in
Contributor
|
Very nice! 😄 |
aleclarson
added a commit
to aleclarson/react-native
that referenced
this pull request
Feb 9, 2016
Summary: `debugger.html` contained a ton of hacky code that was needed to ensure we have a clean JS runtime every time a client RN app connects. That was needed because we used the page's global environment as runtime. Some time ago WebWorker support was added and now we run RN code inside an isolated WebWorker instance, and we can safely get rid of all these hacks. This has a bunch of nice side-effects: debug reload works faster, `console.log`s are preserved, `debuggerWorker.js` selection doesn't change. Made sure the debugging (breakpoints, etc.) still works as before. Small demo  Closes facebook#5715 Reviewed By: svcscm Differential Revision: D2906602 Pulled By: frantic fb-gh-sync-id: 1a6ab9a5655d7c32ddd23619564e59c377b53a35
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: `debugger.html` contained a ton of hacky code that was needed to ensure we have a clean JS runtime every time a client RN app connects. That was needed because we used the page's global environment as runtime. Some time ago WebWorker support was added and now we run RN code inside an isolated WebWorker instance, and we can safely get rid of all these hacks. This has a bunch of nice side-effects: debug reload works faster, `console.log`s are preserved, `debuggerWorker.js` selection doesn't change. Made sure the debugging (breakpoints, etc.) still works as before. Small demo  Closes facebook/react-native#5715 Reviewed By: svcscm Differential Revision: D2906602 Pulled By: frantic fb-gh-sync-id: 1a6ab9a5655d7c32ddd23619564e59c377b53a35
TL-Yao
pushed a commit
to scantist-ossops-m2/nuclide
that referenced
this pull request
Aug 7, 2024
* Add commands for debugging non-Buck React Native apps (requires [react-native#5717](facebook/react-native#5715)) * Add commands for running RN Packager without building via Buck * Fixed “unknown call” warning in RN element inspector * Added limit on Clang server memory usage * Improvements to datatip UX: Datatips disappear on keydown, and the default delay is now 200ms and can be configured in settings (Packages > Nuclide > Nuclide-datatip > debounce delay). Also improved the mapping of mouse coordinates to code.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debugger.htmlcontained a ton of hacky code that was needed to ensure we have a clean JS runtime every time a client RN app connects. That was needed because we used the page's global environment as runtime. Some time ago WebWorker support was added and now we run RN code inside an isolated WebWorker instance, and we can safely get rid of all these hacks.This has a bunch of nice side-effects: debug reload works faster,
console.logs are preserved,debuggerWorker.jsselection doesn't change.Made sure the debugging (breakpoints, etc.) still works as before.
Small demo
