Skip to content

Implement TextInput.selectTextOnFocus for Android #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgladkov wants to merge 3 commits into from
Closed

Implement TextInput.selectTextOnFocus for Android #6654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec3d94d
Implement TextInput.selectTextOnFocus for Android
dgladkov Mar 25, 2016
08b65e0
Merge branch 'master' of https://github.com/facebook/react-native int…
dgladkov Mar 30, 2016
bee3ffe
Merge branch 'master' into android-select-text-on-focus
dgladkov Mar 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Components/TextInput/TextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ var TextInput = React.createClass({
clearTextOnFocus: PropTypes.bool,
/**
* If true, all text will automatically be selected on focus
* @platform ios
*/
selectTextOnFocus: PropTypes.bool,
/**
Expand Down Expand Up @@ -524,6 +523,7 @@ var TextInput = React.createClass({
underlineColorAndroid={this.props.underlineColorAndroid}
children={children}
editable={this.props.editable}
selectTextOnFocus={this.props.selectTextOnFocus}
/>;

return (
Expand Down
5 changes: 5 additions & 0 deletions ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,11 @@ public void setSelectionColor(ReactEditText view, @Nullable Integer color) {
}
}

@ReactProp(name = "selectTextOnFocus", defaultBoolean = false)
public void setSelectTextOnFocus(ReactEditText view, boolean selectTextOnFocus) {
view.setSelectAllOnFocus(selectTextOnFocus);
}

@ReactProp(name = ViewProps.COLOR, customType = "Color")
public void setColor(ReactEditText view, @Nullable Integer color) {
if (color == null) {
Expand Down