Skip to content

[RFC] Add support for missing XHR response types #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidaurelio wants to merge 7 commits into from
Closed

[RFC] Add support for missing XHR response types #6870

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5c6126
Add support for missing XHR response types
davidaurelio Apr 7, 2016
d667a6c
Clean up and add type annotations
davidaurelio Apr 7, 2016
673d302
Fix utf8 encoding, pass content-type to Blob
davidaurelio Apr 8, 2016
411f590
Use invariant when checking responseType
davidaurelio Apr 8, 2016
046800c
Add helpful comments
davidaurelio Apr 8, 2016
f8b10ab
Flow + comments
davidaurelio Apr 11, 2016
7bf8627
Syntax
davidaurelio Apr 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Syntax
  • Loading branch information
@davidaurelio
davidaurelio committed Apr 11, 2016
commit 7bf8627bcf1232aee6234865464bfeb7452a8fda
4 changes: 2 additions & 2 deletions Libraries/Utilities/utf8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ exports.encode = (string: string): ArrayBuffer => {
const {length} = string;
const bytes = new ByteVector(length);

// each character / char code is assumed to represent an UTF-16 wchar
// with the notable exception of surrogate pairs, each wchar represents the
// each character / char code is assumed to represent an UTF-16 wchar.
// With the notable exception of surrogate pairs, each wchar represents the
// corresponding unicode code point.
// For an explanation of UTF-8 encoding, read [1]
// For an explanation of UTF-16 surrogate pairs, read [2]
Expand Down