Skip to content

[Fix] RefreshControl Position Bug #9249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GantMan wants to merge 11 commits into from
Closed

[Fix] RefreshControl Position Bug #9249

Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c7a57db
quickfix for Refresh bug #7976
GantMan Aug 5, 2016
f451ea8
fix linting errors
GantMan Aug 7, 2016
a76d635
Merge branch 'master' into fix/refreshcontrol
GantMan Aug 7, 2016
cd30e6f
Merge branch 'master' into fix/refreshcontrol
GantMan Aug 8, 2016
e1d9d29
Merge branch 'master' into fix/refreshcontrol
GantMan Aug 20, 2016
e8f5be6
moves iOS specific fix to ios only code
GantMan Aug 20, 2016
354e3a1
fix merge with master
GantMan Aug 20, 2016
b795887
Merge branch 'master' into fix/refreshcontrol
GantMan Aug 22, 2016
ad9fa45
Merge branch 'master' into fix/refreshcontrol
GantMan Aug 31, 2016
4d9d80c
nits added - ready to roll
GantMan Sep 4, 2016
191f47f
Merge branch 'master' into fix/refreshcontrol
GantMan Sep 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions React/Views/RCTRefreshControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ - (void)layoutSubviews
{
[super layoutSubviews];

// Quick fix for iOS backgroundColor bug #7976 - To be removed on update
Copy link
Contributor

@janicduplessis janicduplessis Aug 31, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this comment to look like
// Fix for bug #...
// TODO: Remove when updating to use iOS 10 refreshControl UIScrollView prop.

if (self.backgroundColor == nil) self.backgroundColor = [UIColor clearColor];
Copy link
Contributor

@janicduplessis janicduplessis Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: put if content on new line with brackets.


// If the control is refreshing when mounted we need to call
// beginRefreshing in layoutSubview or it doesn't work.
if (_currentRefreshingState && _isInitialRender && _initialRefreshingState) {
Expand Down