Skip to content

Push host root context when bailing out on low priority #10712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 1 commit into from
Sep 14, 2017
+3 −0
Merged

Push host root context when bailing out on low priority #10712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/renderers/shared/fiber/ReactFiberBeginWork.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,6 +686,9 @@ module.exports = function<T, P, I, TI, PI, C, CX, PL>(
// TODO: Handle HostComponent tags here as well and call pushHostContext()?
Copy link
Collaborator

@gaearon gaearon Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this TODO btw?

Copy link
Collaborator Author

@acdlite acdlite Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the same issue, but for HostComponents. This whole function is a code smell, IMO. Ideally we'd bail out on low priority before we ever call performUnitOfWork. I tried this out on my big refactor PR from earlier this summer. Will revisit when we add back resuming.

// See PR 8590 discussion for context
switch (workInProgress.tag) {
case HostRoot:
pushHostRootContext(workInProgress);
break;
case ClassComponent:
pushContextProvider(workInProgress);
break;
Expand Down