Skip to content

Added component stack to contentEditable warning #11208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 2 commits into from
Oct 18, 2017
Merged

Added component stack to contentEditable warning #11208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
544fa78
Added component stack to contentEditable warning
Ethan-Arrowood Oct 6, 2017
75a2533
Added component stack to contentEditable warning
Ethan-Arrowood Oct 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added component stack to contentEditable warning
  • Loading branch information
@Ethan-Arrowood
Ethan-Arrowood committed Oct 12, 2017
commit 75a2533db9f5c2dbfc864c3f68fbf528e99e65af
2 changes: 1 addition & 1 deletion src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,7 +1130,7 @@ describe('ReactDOMComponent', () => {
'Warning: A component is `contentEditable` and contains `children` ' +
'managed by React. It is now your responsibility to guarantee that ' +
'none of those nodes are unexpectedly modified or duplicated. This ' +
'is probably not intentional.\n in div (at **)'
'is probably not intentional.\n in div (at **)',
);
});

Expand Down
10 changes: 5 additions & 5 deletions src/renderers/dom/shared/utils/assertValidProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ function assertValidProps(
props.suppressContentEditableWarning ||
!props.contentEditable ||
props.children == null,
'A component is `contentEditable` and contains `children` managed by ' +
'React. It is now your responsibility to guarantee that none of ' +
'those nodes are unexpectedly modified or duplicated. This is ' +
'probably not intentional.%s',
getCurrentFiberStackAddendum() || '',
'A component is `contentEditable` and contains `children` managed by ' +
'React. It is now your responsibility to guarantee that none of ' +
'those nodes are unexpectedly modified or duplicated. This is ' +
'probably not intentional.%s',
getCurrentFiberStackAddendum() || '',
);
}
invariant(
Expand Down