Parameter for Arrary.indexOf should be the value of the element.#1574
Closed
betarabbit wants to merge 1 commit into
Closed
Parameter for Arrary.indexOf should be the value of the element.#1574betarabbit wants to merge 1 commit into
betarabbit wants to merge 1 commit into
Conversation
Parameter for Arrary.indexOf should be the value of the element, not the index of the element.
Collaborator
|
promiseIndexes is a list of indexes into _promises, so I believe this is correct as-is. |
Member
|
I think @spicyj is right but since that code isn't actually used, I'm not sure... @fisherwebdev? |
Collaborator
|
I think #1575 makes this logic clearer. |
Contributor
|
@spicyj is correct here. |
This was referenced Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameter for Arrary.indexOf should be the value of the element, not the index of the element.