Skip to content

Fix test_build_devtools CI job to run test-build-devtools #17631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvaughn merged 6 commits into from
Dec 17, 2019
Merged

Fix test_build_devtools CI job to run test-build-devtools #17631

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
209ced0
Skip abandoned project folders in Jest config
gaearon Dec 16, 2019
549f1be
Fix test_build_devtools to run test-build-devtools
gaearon Dec 16, 2019
3233d78
Exclude console.error plugin for DevTools packages
gaearon Dec 16, 2019
2049b94
Use correct release channel for DevTools tests
gaearon Dec 16, 2019
386796d
Fix TZ dependent test
gaearon Dec 16, 2019
9cea553
Change DT job dependencies
gaearon Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Exclude console.error plugin for DevTools packages
  • Loading branch information
@gaearon
gaearon committed Dec 16, 2019
commit 3233d7848748ca0e49b49ce6cfa900f2d62d6e05
11 changes: 7 additions & 4 deletions scripts/jest/preprocessor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,14 @@ module.exports = {
// for test files, we also apply the async-await transform, but we want to
// make sure we don't accidentally apply that transform to product code.
const isTestFile = !!filePath.match(/\/__tests__\//);
const isInDevToolsPackages = !!filePath.match(
/\/packages\/react-devtools.*\//
);
const testOnlyPlugins = [pathToBabelPluginAsyncToGenerator];
const sourceOnlyPlugins =
process.env.NODE_ENV === 'development'
? [pathToBabelPluginReplaceConsoleCalls]
: [];
const sourceOnlyPlugins = [];
if (process.env.NODE_ENV === 'development' && !isInDevToolsPackages) {
Copy link
Contributor

@bvaughn bvaughn Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

sourceOnlyPlugins.push(pathToBabelPluginReplaceConsoleCalls);
}
const plugins = (isTestFile ? testOnlyPlugins : sourceOnlyPlugins).concat(
babelOptions.plugins
);
Expand Down