Skip to content

Extract errors from Error() and new Error() instead of invariant() #22514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebmarkbage wants to merge 5 commits into from
Closed

Extract errors from Error() and new Error() instead of invariant() #22514

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e37bd8a
Extract errors from Error() and new Error() instead of invariant()
sebmarkbage Oct 6, 2021
b12601b
Ignore extracting errors if the build isn't minified anyway
sebmarkbage Oct 6, 2021
470a376
Don't minify noop builds
sebmarkbage Oct 6, 2021
b1a0616
Don't both minifying error messages in React I/O libraries
sebmarkbage Oct 6, 2021
1c3faf1
Newly discovered errors
sebmarkbage Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore extracting errors if the build isn't minified anyway
  • Loading branch information
@sebmarkbage
sebmarkbage committed Oct 6, 2021
commit b12601b2fd7189097c99f5a23f1ac0003c39c8a8
11 changes: 6 additions & 5 deletions scripts/rollup/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,12 +361,13 @@ function getPlugins(
const shouldStayReadable = isFBWWWBundle || isRNBundle || forcePrettyOutput;
return [
// Extract error codes from invariant() messages into a file.
shouldExtractErrors && {
transform(source) {
findAndRecordErrorCodes(source);
return source;
shouldExtractErrors &&
bundle.minifyWithProdErrorCodes !== false && {
transform(source) {
findAndRecordErrorCodes(source);
return source;
},
},
},
// Shim any modules that need forking in this environment.
useForks(forks),
// Ensure we don't try to bundle any fbjs modules.
Expand Down