Skip to content

Fix Missing key Validation in React.Children #29675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yungsters merged 4 commits into from
May 31, 2024
Merged

Fix Missing key Validation in React.Children #29675

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a6212d
Fix Missing `key` Validation in `React.Children`
yungsters May 30, 2024
2897d38
Fix Flow errors
yungsters May 30, 2024
63f6541
Prettier...
yungsters May 30, 2024
5d26f17
Restore `cloneAndReplaceKey` changes
yungsters May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Flow errors
  • Loading branch information
@yungsters
yungsters committed May 30, 2024
commit 2897d38edc367182b3d0a7bcf08e4acacb67558a
3 changes: 2 additions & 1 deletion packages/react/src/ReactChildren.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ function mapIntoArray(
if (__DEV__) {
// If `child` was an element without a `key`, we need to validate if
// it should have had a `key`, before assigning one to `mappedChild`.
if (nameSoFar !== '' && isValidElement(child) && child.key == null) {
// $FlowFixMe[incompatible-type] Flow incorrectly thinks React.Portal doesn't have a key
Copy link
Contributor

@sebmarkbage sebmarkbage May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is weird that React.Children doesn't operate on portals. They don't get assigned keys.

Copy link
Contributor Author

@yungsters yungsters May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I copied this from the $FlowFixMe comments in the lines above. 😅

Copy link
Contributor

@sebmarkbage sebmarkbage May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but I found it interesting that 1) we didn't refine the type above 2) that we're checking isValidElement at all.

if (nameSoFar !== '' && child != null && isValidElement(child) && child.key == null) {
// We check truthiness of `child._store.validated` instead of being
// inequal to `1` to provide a bit of backward compatibility for any
// libraries (like `fbt`) which may be hacking this property.
Expand Down