Update tooling docs to suggest babel#4546
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Done deal. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Let's just drop the last sentence here – no one will remember react-tools in a few months anyway.
|
Thanks! Can you link to http://babeljs.io/docs/usage/browser/ instead of JSXTransformer.js too? |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Linked to the browser page on babeljs as well, though it doesn't provide a download link (so I had to reword the section). |
|
All done with revisions. Thanks @spicyj! |
|
Awesome work. Do you mind squashing your commits together? |
|
Not a problem at all. I'll squish and report back. |
`react-tools` is deprecated, `babel` is our future * https://facebook.github.io/react/blog/2015/06/12/deprecating-jstransform-and-react-tools.html * https://babeljs.io/docs/usage/jsx/
|
All set! |
Update tooling docs to suggest babel
|
Thank you @rgbkrk! |
|
Would you be interested in doing a scan of the rest of our docs and see where else we are talking about using JSXTransformer (and |
|
A quick pass shows fixes certainly need to be made in the Japanese and Korean versions of the docs, but I certainly can't fix those. 😉 I've got to run so I can't scan this evening. runs off and doesn't click Apparently I had to run so quick that I left this comment but didn't submit it. Sorry! Were you able to get to this @zpao? |
|
I started to and I can finish it up today (I'm going to make some other related changes so will try to get them all in together). |
4 participants
react-toolsis deprecated,babelis our future