Skip to content

add srcLang attribute for track elements#5191

Closed
line-o wants to merge 1 commit into
facebook:masterfrom
line-o:missing-attribute
Closed

add srcLang attribute for track elements#5191
line-o wants to merge 1 commit into
facebook:masterfrom
line-o:missing-attribute

Conversation

@line-o
Copy link
Copy Markdown

@line-o line-o commented Oct 16, 2015

srclang is necessary to determine the language the TextTrack contents are meant for.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@line-o updated the pull request.

Normalized name is missing in `DOMPropertyNames` mapping
@line-o line-o force-pushed the missing-attribute branch from 66f33ed to cf2ef31 Compare October 16, 2015 03:11
@line-o
Copy link
Copy Markdown
Author

line-o commented Oct 16, 2015

Both missing attributes for track-elements from 0.14-stable were already added.
The normalisation was still missing so here it is.
If it is not necessary to add the normalised attribute string just close this PR.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@line-o updated the pull request.

@zpao
Copy link
Copy Markdown
Member

zpao commented Oct 30, 2015

This happened in #5174 (along with other attributes for <track>) and was shipped with 0.14.1. Thanks though and sorry for not getting back to you sooner!

@zpao zpao closed this Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants