ReactTransitionGroup can handle components being re-added before 'leave' transition has completed.#642
Merged
Merged
Conversation
added 2 commits
December 6, 2013 14:46
… new one no longer bug-out. In the case of having an animated node which is, after the leave-transition has been activated, then re-added in a render call causes React to 'break'. This is especially noticeable if you spam to removal and re-addition of an item in a ReactTransitionGroup. This fix simply stops the leave transition and restarts the enter transition.
Member
|
cc @petehunt |
Contributor
|
This lgtm, need to do some stuff then I can merge it! |
petehunt
added a commit
that referenced
this pull request
Dec 23, 2013
ReactTransitionGroup can handle components being re-added before 'leave' transition has completed.
Contributor
|
This PR is mistitled -- it doesn't fix the issue for |
Contributor
Author
|
@jedwards1211: Heh - the PR is almost two years old now! |
Contributor
|
@Cartas oh, hah! Well in any case there's been a lot of work on fixing issues with |
This was referenced Aug 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's quite possible to end up with DOM elements within ReactTransitionGroups staying behind despite the leave transition having ended. This occurs when calling render which then attempts to add the same element to the Group at the same time as it is being removed/transitioning-out.
These elements remain behind, with their class forever set to 'name-leave name-leave-active'. In this instance I simply remove the 'leave' classes and re-add the 'enter' ones if necessary, to make the elements nicely reverse their animation/come back into view.
Fixes #649.
PS: I've signed the CLA with this github username.