Fix shouldUpdateReactComponent not considering props.key#711
Closed
syranide wants to merge 1 commit into
Closed
Conversation
Contributor
|
I think that makes sense. cc @yungsters |
Collaborator
|
See #591. |
Contributor
Author
|
@spicyj Ah, look at that. Yeah, your PR looks perfect, just need to light someones ass on fire then. :) So this PR should be closed. |
Contributor
|
Let's go with @spicyj's PR. Sorry, but thanks for lighting the fire! |
Contributor
Author
|
@petehunt No need to be "sorry", it's the right decision. :) |
josephsavona
added a commit
that referenced
this pull request
May 15, 2024
Redo of #711 Note that one test (switch.js) is failing, i'm working on a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently @spicyj already has a pending PR for this that should be considered instead, #591.
keyis currently only obeyed by descendants of the root-node, the root-node itself does not obeykey. This simple fix ensures that it works on the root-node as well.I would consider this a bug and speaking hastily to petehunt, he seemed to agree:
<@petehunt> yeah i think that would be a bugMy personal motivation for this is my
<swf>-component that I will be releasing, it requires this to support changingsrcat run-time (although other workarounds do exist). In my opinion, there's no reason why the root-node should be any different from the other children in this regard.