Conversation
terrelln
approved these changes
Jan 5, 2018
Contributor
Author
|
I'm not completely satisfied by the usefulness of this patch. But the result is underwhelming : there are indeed more combinations, but they merely allow to move along the same line of trade-off, with no noticeable "win" (improving both speed and compression ratio). Therefore, this patch adds complexity, but doesn't deliver much in exchange. Therefore, I'll put this patch aside for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for
targetLengthparameter for "lazy" strategies (zstd_lazy.c).The impact is moderate, because lazy strategies already skip a lot of positions by design (in contrast with optimal, which may only skip when it reaches
targetLength). For lazy strategy,targetLengthparameter triggers skip a bit more often, mostly when the value oftargetLengthis small enough.All compression level tables have been updated to use the new parameter.
The impact is not earth shattering. Mostly, it translates into a different position in the speed / compression curb. Levels 6-9 are where the impact is most visible, and even then, it remains a relatively small improvement.