This repository was archived by the owner on Dec 26, 2019. It is now read-only.
Added support to get source for WKWebView#964
Open
sumanc wants to merge 3 commits intofacebookarchive:masterfrom
Open
Added support to get source for WKWebView#964sumanc wants to merge 3 commits intofacebookarchive:masterfrom
sumanc wants to merge 3 commits intofacebookarchive:masterfrom
Conversation
Contributor
|
This is kind of weird that force resolving that is necessary. Could you add test case for that as well? |
Author
|
I can try. I just looked at the project's structure. I need to add a WKWebview based view controller to the integration and add a test case in the integration tests? Please send me if there are any guidelines to add a test case. |
|
I had the same issue with Webviews and this commit fixed it. Thanks @sumanc . |
…nto WKWebView-Support
…ible Support for tap when system dialog is up Getting source was very slow when system dialog is up. Removed the test on the child object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When I use the following command;
curl -X GET $JSON_HEADER $DEVICE_UL/session/7D046797-5D22-4E16-8264-754C5A1C4796/source
and if the app has a WKWebView, I am not getting any elements from the WKWebView.
I couldn't find any place else other than this pull request. With this change, I am able to get the complete source of the app including the WKWebView.
Please let me know if this is the right thing todo or if there is a better way.
--Suman