Four fixes for RASP Tutorial#391
Four fixes for RASP Tutorial#391roelbertens wants to merge 6 commits intofacebookresearch:masterfrom
Conversation
|
Hi @roelbertens! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
-fix SPARK_JAR path
|
@MisterTea has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Summary: When trying to follow the [tutorial](https://reagent.ai/rasp_tutorial.html) there are a few things that need fixing: 1. When running the script serving/scripts/rasp_to_model.py I came across this error ``` python serving/scripts/rasp_to_model.py /tmp/rasp_logging/log.txt /tmp/input_df.pkl Traceback (most recent call last): File "serving/scripts/rasp_to_model.py", line 13, in <module> logger.setLevel(logging.info) File "/usr/local/anaconda3/envs/reagent/lib/python3.7/logging/__init__.py", line 1353, in setLevel self.level = _checkLevel(level) File "/usr/local/anaconda3/envs/reagent/lib/python3.7/logging/__init__.py", line 195, in _checkLevel raise TypeError("Level not an integer or a valid string: %r" % level) TypeError: Level not an integer or a valid string: <function info at 0x7fb8000d73b0> ``` Luckily it is an easy fix to pass an actual loglevel. 2. This config file probably is outdated: serving/examples/ecommerce/training/contextual_bandit.yaml - changed indentation level - changed key name 3. There is an __init__.py file missing in the gym tests therefore leading to an error 4. The path to the SPARK_JAR was not resolving correctly. Pull Request resolved: facebookresearch#391 Test Plan: Imported from GitHub, without a `Test Plan:` line. ...but without running open source tests. Reviewed By: czxttkl Differential Revision: D27842451 Pulled By: MisterTea fbshipit-source-id: 1531981ae918c05c9d5e844928eed8d12002ea1d
|
@MisterTea merged this pull request in 322a542. |
Summary: Pull Request resolved: #458 When trying to follow the [tutorial](https://reagent.ai/rasp_tutorial.html) there are a few things that need fixing: 1. When running the script serving/scripts/rasp_to_model.py I came across this error ``` python serving/scripts/rasp_to_model.py /tmp/rasp_logging/log.txt /tmp/input_df.pkl Traceback (most recent call last): File "serving/scripts/rasp_to_model.py", line 13, in <module> logger.setLevel(logging.info) File "/usr/local/anaconda3/envs/reagent/lib/python3.7/logging/__init__.py", line 1353, in setLevel self.level = _checkLevel(level) File "/usr/local/anaconda3/envs/reagent/lib/python3.7/logging/__init__.py", line 195, in _checkLevel raise TypeError("Level not an integer or a valid string: %r" % level) TypeError: Level not an integer or a valid string: <function info at 0x7fb8000d73b0> ``` Luckily it is an easy fix to pass an actual loglevel. 2. This config file probably is outdated: serving/examples/ecommerce/training/contextual_bandit.yaml - changed indentation level - changed key name 3. There is an __init__.py file missing in the gym tests therefore leading to an error 4. The path to the SPARK_JAR was not resolving correctly. Pull Request resolved: #391 Test Plan: Imported from GitHub, without a `Test Plan:` line. ...but without running open source tests. Reviewed By: czxttkl Differential Revision: D27842451 Pulled By: MisterTea fbshipit-source-id: 2175296c6b60db4dc4b22804a74c2259b14fee7e
When trying to follow the tutorial there are a few things that need fixing:
Luckily it is an easy fix to pass an actual loglevel.
There is an init.py file missing in the gym tests therefore leading to an error
The path to the SPARK_JAR was not resolving correctly.