Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66789357 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Summary: This diff splits `character_test_helpers` into two modules: `character_test_helpers` (no gtest dependency) and `character_test_helpers_gtest` (with gtest dependency). The goal is to remove gtest dependencies from all pymomentum submodules. `character_test_helpers_gtest` will be only used for C++ testing. Previously, a separate `geometry_test_helper` submodule was created (D63378477) to remove gtest dependencies from `geometry`. However, it was found that any pymomentum submodule with a gtest dependency is problematic. This diff aims to completely remove gtest dependencies from all pymomentum submodules. Differential Revision: D66789357
Summary: To have consistent name convention with other test helper targets (e.g., `test_helpers`) Reviewed By: cdtwigg Differential Revision: D66787080
Summary: This diff splits `character_test_helpers` into two modules: `character_test_helpers` (no gtest dependency) and `character_test_helpers_gtest` (with gtest dependency). The goal is to remove gtest dependencies from all pymomentum submodules. `character_test_helpers_gtest` will be only used for C++ testing. Previously, a separate `geometry_test_helper` submodule was created (D63378477) to remove gtest dependencies from `geometry`. However, it was found that any pymomentum submodule with a gtest dependency is problematic. This diff aims to completely remove gtest dependencies from all pymomentum submodules. Reviewed By: cdtwigg Differential Revision: D66789357
jeongseok-meta
force-pushed
the
export-D66789357
branch
from
67cfff1 to
590d3ee
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66789357 |
jeongseok-meta
added a commit
that referenced
this pull request
Dec 6, 2024
Summary: This diff splits `character_test_helpers` into two modules: `character_test_helpers` (no gtest dependency) and `character_test_helpers_gtest` (with gtest dependency). The goal is to remove gtest dependencies from all pymomentum submodules. `character_test_helpers_gtest` will be only used for C++ testing. Previously, a separate `geometry_test_helper` submodule was created (D63378477) to remove gtest dependencies from `geometry`. However, it was found that any pymomentum submodule with a gtest dependency is problematic. This diff aims to completely remove gtest dependencies from all pymomentum submodules. Reviewed By: cdtwigg Differential Revision: D66789357
jeongseok-meta
added a commit
that referenced
this pull request
Dec 6, 2024
Summary: This diff splits `character_test_helpers` into two modules: `character_test_helpers` (no gtest dependency) and `character_test_helpers_gtest` (with gtest dependency). The goal is to remove gtest dependencies from all pymomentum submodules. `character_test_helpers_gtest` will be only used for C++ testing. Previously, a separate `geometry_test_helper` submodule was created (D63378477) to remove gtest dependencies from `geometry`. However, it was found that any pymomentum submodule with a gtest dependency is problematic. This diff aims to completely remove gtest dependencies from all pymomentum submodules. Reviewed By: cdtwigg Differential Revision: D66789357
jeongseok-meta
added a commit
that referenced
this pull request
Dec 6, 2024
Summary: This diff splits `character_test_helpers` into two modules: `character_test_helpers` (no gtest dependency) and `character_test_helpers_gtest` (with gtest dependency). The goal is to remove gtest dependencies from all pymomentum submodules. `character_test_helpers_gtest` will be only used for C++ testing. Previously, a separate `geometry_test_helper` submodule was created (D63378477) to remove gtest dependencies from `geometry`. However, it was found that any pymomentum submodule with a gtest dependency is problematic. This diff aims to completely remove gtest dependencies from all pymomentum submodules. Reviewed By: cdtwigg Differential Revision: D66789357
Contributor
|
This pull request has been merged in cbb0254. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff splits
character_test_helpersinto two modules:character_test_helpers(no gtest dependency) andcharacter_test_helpers_gtest(with gtest dependency). The goal is to remove gtest dependencies from all pymomentum submodules.character_test_helpers_gtestwill be only used for C++ testing.Previously, a separate
geometry_test_helpersubmodule was created (D63378477) to remove gtest dependencies fromgeometry. However, it was found that any pymomentum submodule with a gtest dependency is problematic. This diff aims to completely remove gtest dependencies from all pymomentum submodules.Differential Revision: D66789357