fix(striped_backups): changed logic to get all striped backups - #62
Merged
Alex Irion (alexirion10) merged 19 commits intoMar 11, 2021
Merged
Conversation
Aditya Niraula (AdityaNPL)
changed the title
Aditya Niraula (AdityaNPL)
marked this pull request as ready for review
March 1, 2021 16:29
Alex Irion (alexirion10)
left a comment
Alex Irion (alexirion10)
left a comment
Contributor
There was a problem hiding this comment.
I think the logic in here is right... but this needs to be tested more thouroughly
…on PR suggestions
Contributor
Author
|
Sure, I have tested locally with a MSSQL instance that has striped backups - worked correctly Will also try to add some negative tests by adding duplicates and diff/full backups with diff LSNs |
Alex Irion (alexirion10)
approved these changes
Mar 1, 2021
Aditya Niraula (AdityaNPL)
force-pushed
the
fix/striped_backups
branch
from
March 2, 2021 19:39
c01549d to
8abb6ab
Compare
Alex Irion (alexirion10)
approved these changes
Mar 8, 2021
Alex Irion (alexirion10)
left a comment
Alex Irion (alexirion10)
left a comment
Contributor
There was a problem hiding this comment.
two small fixes, then good to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes backups are split into multiple files (called
stripedbackup), we need all of them for the restore process.ref: https://www.sqlservercentral.com/articles/getting-a-list-of-the-striped-backup-files