Skip to content

refactor(listener): internalsVisibleTo moved to csproj and small changes in comments #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex Irion (alexirion10) merged 2 commits into from
Mar 11, 2021
Merged

refactor(listener): internalsVisibleTo moved to csproj and small changes in comments #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf277d
Merge pull request #5 from factset/master
AdityaNPL Mar 11, 2021
0bfa8a3
refactor(listener): internalsVisibleTo moved to csproj and small chan…
AdityaNPL Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/AgDatabaseMove.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,8 @@
</Reference>
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="AgDatabaseMove.Unit" />
</ItemGroup>

</Project>
3 changes: 1 addition & 2 deletions src/SmoFacade/Listener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("AgDatabaseMove.Unit")]
namespace AgDatabaseMove.SmoFacade
{
using System;
Expand Down Expand Up @@ -147,7 +146,7 @@ private static Server AgInstanceNameToServer(ref SqlConnectionStringBuilder conn

/// <summary>
/// Resolves 'agReplicaInstanceName' to a FQDN
/// However on Unix OS, when 'val' in 'Dns.GetHostEntry(val)' is not a complete domain (i.e is just "abc", instead of "abc.def.com"), it fails intermittently
/// However on Unix OS, when 'val' in 'Dns.GetHostEntry(val)' is not a FQDN, it fails intermittently
/// Therefore, if dns lookup on just the instance name fails, we retry after appending the domain fragments from the listener to the instance name
/// </summary>
/// <param name="agReplicaInstanceName"> The name for an instance within the AG (for which we are trying to get the FQDN)</param>
Expand Down