Remove all default features. Making them opt-in#57
Merged
Conversation
0c5be96 to
a056ca5
Compare
Open
a056ca5 to
a4098c4
Compare
a4098c4 to
79d6f52
Compare
79d6f52 to
7351079
Compare
7351079 to
827e5a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for this is outlined in the comment in
Cargo.tomlin the PR content itself.Before this can be merged, I need to add fancy documentation helper tags that makes everything show up neatly on docs.rs.
We can also consider dropping the
asyncfeature and always support at least async receiving. It will compile in some unnecessary complexity, but maybe it's negligible compared to the complexity of keeping some of the code conditionally compiled etc. We should probably not remove thestdfeature, since it's needed to allow making the crateno_std. However, it can be discussed whether it's better renamed toblockingor similar. Since what it allows is blocking receive operations, which happens to have the side effect of requiring the standard library.