MSVC Build Failure on Windows with vcpkg - Maximum recursion depth exceeded.

[zzeddo]

Environment

• OS: Windows
• Compiler: MSVC (Visual Studio 17 2022)
• Architecture: x64
• vcpkg: Latest version (installed at C:\vcpkg)
• Windows SDK: 10.0.26100.0

Issue Description

The project fails to build on Windows using MSVC with vcpkg toolchain due to a maximum recursion depth error in vcpkg.cmake.

Steps to Reproduce

1. Install vcpkg:

   git clone https://github.com/Microsoft/vcpkg.git C:\vcpkg
   cd C:\vcpkg
   .\bootstrap-vcpkg.bat
   .\vcpkg integrate install

2. Install required dependencies:

   .\vcpkg install openssl:x64-windows
   .\vcpkg install zlib:x64-windows
   .\vcpkg install zeromq:x64-windows

3. Configure the project:

   cd D:\study\opencmw-cpp-example
   cmake -S . -B build ^
       -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake ^
       -G "Visual Studio 17 2022" -A x64

Error Output

-- Running vcpkg install - done
-- Selecting Windows SDK version 10.0.26100.0 to target Windows 6.2.9200.
-- No colored compiler diagnostic set for 'MSVC' compiler.
WARNNo version check for your compiler (MSVC) implemented, in case of build problems consider updating your compiler or check if you can switch to gcc or clang
CMake Error at C:/vcpkg/scripts/buildsystems/vcpkg.cmake:152 (if):
  Maximum recursion depth of 1000 exceeded
Call Stack (most recent call first):
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:640 (z_vcpkg_function_arguments)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:641 (_add_library)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:641 (_add_library)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:641 (_add_library)
  [... repeated many times ...]
  CMakeLists.txt:26 (add_library)
-- Configuring incomplete, errors occurred!

Expected Behavior

The project should configure and build successfully on Windows with MSVC using vcpkg.

Additional Information

• The warning mentions "No version check for your compiler (MSVC) implemented"
• The recursion occurs in the vcpkg toolchain file when processing add_library calls
• The error originates from line 26 in CMakeLists.txt

Possible Solutions to Investigate

1. Check for CMakeLists.txt compatibility with vcpkg toolchain
2. Verify if there are any circular dependencies in the build configuration
3. Consider alternative build approaches for Windows/MSVC environment

Any guidance on resolving this MSVC build issue would be greatly appreciated.

[wirew0rm]

Hey and thanks for your interest in opencmw :)

I'm afraid we won't be able to offer a lot of assistance on this, since we do not have any developers using windows, msvc or cvpkg. The line linked to from the log you provided also looks innocent enough and I have no idea why defining an interface target could trigger an infinite recursion. Since the rest of the error log is inside of vcpkg, I don't think I'll be able to investigate this.

If you maybe with help from the vcpkg community can find out why this issue get's triggered, we'd be happy to accept a PR which implements windows compatibilty, just be aware that you are probably the first one going down this path, so there might be some more issues down that road that you would have to fix.

Alternatively you could build in a linux environment (virtual machine or WSL) which would probbaly be the easier way (of course depending on what your goal is).