Skip to content

Remove duplicate reference link in README.md#3217

Merged
jremes-foss merged 1 commit intofaker-ruby:mainfrom
yutasb:fix/readme_duplicate_reference
Feb 25, 2026
Merged

Remove duplicate reference link in README.md#3217
jremes-foss merged 1 commit intofaker-ruby:mainfrom
yutasb:fix/readme_duplicate_reference

Conversation

@yutasb
Copy link
Contributor

@yutasb yutasb commented Feb 25, 2026

Motivation / Background

This Pull Request has been created because the [downloads-badge] reference link was defined twice in README.md (lines 13-14) with identical URLs. According to the Markdown specification, only the first definition is used when multiple definitions exist for the same reference name. The duplicate definition on line 14 serves no purpose and reduces code clarity.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

Copy link
Contributor

@jremes-foss jremes-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@jremes-foss jremes-foss merged commit 9ef1eca into faker-ruby:main Feb 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants