Skip to content

chore: fix the inconsistent stream error log message #238

Merged
FrenchGithubUser merged 1 commit intomasterfrom
syk/fix-stream-error-log
Feb 26, 2026
Merged

chore: fix the inconsistent stream error log message #238
FrenchGithubUser merged 1 commit intomasterfrom
syk/fix-stream-error-log

Conversation

@itsoyou
Copy link
Member

@itsoyou itsoyou commented Feb 26, 2026

  • fix the inconsistent stream error log message to contain the proper information instead of raising value error
  • fix typo

@itsoyou itsoyou requested a review from a team as a code owner February 26, 2026 08:15
Copilot AI review requested due to automatic review settings February 26, 2026 08:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a broken/inconsistent formatting string used when raising the “inconsistent stream” database setup error, and corrects a small typo in request helper docstrings used in tests.

Changes:

  • Fix _INCONSISTENT_STREAM_ERROR to use valid %() mapping placeholders so formatting no longer raises a ValueError.
  • Correct “pretenting” → “pretending” in make_request docstrings in test helpers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
synapse/storage/util/sequence.py Fixes mapping-style % placeholders in the inconsistent stream error message so it formats correctly with the provided dict.
tests/unittest.py Fixes a typo in the make_request docstring parameter description.
tests/server.py Fixes the same typo in the shared make_request docstring parameter description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.12%. Comparing base (e9af5a2) to head (47df28f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   80.13%   80.12%   -0.01%     
==========================================
  Files         500      500              
  Lines       71220    71220              
  Branches    10703    10703              
==========================================
- Hits        57069    57065       -4     
- Misses      10906    10910       +4     
  Partials     3245     3245              
Files with missing lines Coverage Δ
synapse/storage/util/sequence.py 92.30% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9af5a2...47df28f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrenchGithubUser FrenchGithubUser force-pushed the syk/fix-stream-error-log branch 2 times, most recently from fa9f7d1 to 34376ce Compare February 26, 2026 14:01
…roper information instead of rasing value error
@FrenchGithubUser FrenchGithubUser added this pull request to the merge queue Feb 26, 2026
Merged via the queue into master with commit 8df5163 Feb 26, 2026
25 of 28 checks passed
@FrenchGithubUser FrenchGithubUser deleted the syk/fix-stream-error-log branch February 26, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants