chore: fix the inconsistent stream error log message #238
chore: fix the inconsistent stream error log message #238FrenchGithubUser merged 1 commit intomasterfrom
Conversation
itsoyou
commented
Feb 26, 2026
- fix the inconsistent stream error log message to contain the proper information instead of raising value error
- fix typo
There was a problem hiding this comment.
Pull request overview
This PR fixes a broken/inconsistent formatting string used when raising the “inconsistent stream” database setup error, and corrects a small typo in request helper docstrings used in tests.
Changes:
- Fix
_INCONSISTENT_STREAM_ERRORto use valid%()mapping placeholders so formatting no longer raises aValueError. - Correct “pretenting” → “pretending” in
make_requestdocstrings in test helpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
synapse/storage/util/sequence.py |
Fixes mapping-style % placeholders in the inconsistent stream error message so it formats correctly with the provided dict. |
tests/unittest.py |
Fixes a typo in the make_request docstring parameter description. |
tests/server.py |
Fixes the same typo in the shared make_request docstring parameter description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
==========================================
- Coverage 80.13% 80.12% -0.01%
==========================================
Files 500 500
Lines 71220 71220
Branches 10703 10703
==========================================
- Hits 57069 57065 -4
- Misses 10906 10910 +4
Partials 3245 3245
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
fa9f7d1 to
34376ce
Compare
…roper information instead of rasing value error
34376ce to
47df28f
Compare