feat: threadline theme#240
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
vercel
Bot
temporarily deployed
to
Preview – farming-labs-docs-docs-cloud
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="website/app/themes/page.tsx">
<violation number="1" location="website/app/themes/page.tsx:116">
P2: Assistant UI example snippet is incomplete: it enables `assistantUIPageActions` but omits required `github.url`, so the GitHub page action won’t work when users copy this config.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
5 issues found across 15 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/fumadocs/package.json">
<violation number="1" location="packages/fumadocs/package.json:91">
P2: Public package entrypoints were renamed without keeping aliases, introducing a breaking API change for existing `assistant-ui` imports.</violation>
</file>
<file name="packages/fumadocs/src/page-actions.tsx">
<violation number="1" location="packages/fumadocs/src/page-actions.tsx:190">
P2: `markdownHref` generation produces `/.md` for root routes, breaking the new rail "View as Markdown" link on site-root docs pages.</violation>
<violation number="2" location="packages/fumadocs/src/page-actions.tsx:291">
P2: Ask AI analytics are emitted even when no AI trigger is found, causing false-positive action metrics for a no-op click.</violation>
<violation number="3" location="packages/fumadocs/src/page-actions.tsx:353">
P1: Early return before variant check silently prevents the rail variant from rendering when `copyMarkdown` and `openDocs` are both false, dropping the unconditional Ask AI button</violation>
</file>
<file name="website/app/themes/page.tsx">
<violation number="1" location="website/app/themes/page.tsx:116">
P2: Threadline usage snippet enables `threadlinePageActions` without `github.url`, which leaves the GitHub page action misconfigured in copied setups.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| "import": "./dist/ledger/index.mjs", | ||
| "default": "./dist/ledger/index.mjs" | ||
| }, | ||
| "./threadline": { |
Contributor
There was a problem hiding this comment.
P2: Public package entrypoints were renamed without keeping aliases, introducing a breaking API change for existing assistant-ui imports.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/fumadocs/package.json, line 91:
<comment>Public package entrypoints were renamed without keeping aliases, introducing a breaking API change for existing `assistant-ui` imports.</comment>
<file context>
@@ -88,10 +88,10 @@
- "types": "./dist/assistant-ui/index.d.mts",
- "import": "./dist/assistant-ui/index.mjs",
- "default": "./dist/assistant-ui/index.mjs"
+ "./threadline": {
+ "types": "./dist/threadline/index.d.mts",
+ "import": "./dist/threadline/index.mjs",
</file context>
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/fumadocs/package.json">
<violation number="1" location="packages/fumadocs/package.json:91">
P2: Public package entrypoints were renamed without keeping aliases, introducing a breaking API change for existing `assistant-ui` imports.</violation>
</file>
<file name="packages/fumadocs/styles/threadline.css">
<violation number="1" location="packages/fumadocs/styles/threadline.css:224">
P2: Theme-toggle exclusion selector is ineffective: CSS excludes `[data-theme-toggle]`, but sidebar theme-toggle markup does not provide that attribute.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| } | ||
|
|
||
| :is(aside#nd-sidebar, aside#nd-sidebar-mobile, .fd-sidebar) | ||
| :is(a, button):not([data-sidebar-control]):not([data-theme-toggle]) { |
Contributor
There was a problem hiding this comment.
P2: Theme-toggle exclusion selector is ineffective: CSS excludes [data-theme-toggle], but sidebar theme-toggle markup does not provide that attribute.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/fumadocs/styles/threadline.css, line 224:
<comment>Theme-toggle exclusion selector is ineffective: CSS excludes `[data-theme-toggle]`, but sidebar theme-toggle markup does not provide that attribute.</comment>
<file context>
@@ -216,7 +221,7 @@ aside#nd-sidebar-mobile .fd-sidebar {
:is(aside#nd-sidebar, aside#nd-sidebar-mobile, .fd-sidebar)
- :is(a, button):not([data-sidebar-control]) {
+ :is(a, button):not([data-sidebar-control]):not([data-theme-toggle]) {
border-radius: 0.375rem !important;
background: transparent !important;
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds the new
@farming-labs/theme/threadlinepreset: a compact, neutral docs shell with a TOC rail for page actions and small back/forward title controls. Examples and docs now use the theme, including a new Threadline docs page.threadline()plus defaultsthreadlinePageActions(TOC rail: Copy page, View as Markdown, Edit on GitHub, Ask AI).position: "toc"andvariant: "rail", smarter Copy Markdown (fetches.mdfirst), Open Docs resolves to.md(root →/index.md), Ask AI trigger.@farming-labs/theme/threadlineand@farming-labs/theme/threadline/css; root re-export in@farming-labs/fumadocs; adds"toc"toPageActionsConfig.threadline()withthreadlinePageActions, theme toggle default to light,lastUpdatedoff;suppressHydrationWarning, NextdevIndicators: false; new docs at/docs/themes/threadlineand themes index updated.Written for commit cb0ec80. Summary will update on new commits.