Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
This reverts commit 9316c78.
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Oct 6, 2025
Comment on lines
+30
to
+35
| #[derive(Debug)] | ||
| pub struct Asynchronous { | ||
| appends: Arc<[Box<dyn Append>]>, | ||
| overflow: Overflow, | ||
| state: AppendState, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Thanks for @ SpriteOvO's spdlog-rs AsyncPoolSink. I borrow most of the design while change the thread pool to a single background thread.
One open issue is about naming. Since async is a keyword now, we'd better use a different name from Async here. Currently I use Asynchronous, but I'd prefer a shorter name. Considering AsyncPool, perhaps AsyncSingleThread or other.
BTW we need to implement a clean up logic atexit, related to SpriteOvO/spdlog-rs#102
tisonkun
commented
Oct 6, 2025
Comment on lines
+77
to
+81
| fn exit(&self) -> Result<(), Error> { | ||
| // fastrace flush accesses thread-local storage, | ||
| // which is not supported in atexit handlers | ||
| Ok(()) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@andylokandy Then we rely on the caller/application to call fastrace::flush on exit, like what we do in ScopeDB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #145.