📝 Use FastAPI lifespan instead of startup event#1687
Closed
Michele0303 wants to merge 8 commits into
Closed
Conversation
Replace deprecated FastAPI startup events in tutorial examples with lifespan context managers, keeping on_startup() as a helper for tests and documentation consistency.
Contributor
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
github-actions
Bot
added
the
conflicts
github-actions
Bot
removed
the
conflicts
Contributor
|
This pull request has a merge conflict that needs to be resolved. |
github-actions
Bot
added
the
conflicts
Member
|
Thanks for the interest and work on this! ☕ I want to implement a big refactor and some features in how to handle these things, I'm not fully happy with the existing interface. I'll do that first, and then update the docs to reflect the recommended way to do things. I don't want to update the docs yet and suggest doing something that later I will suggest doing in a different way. So for now, I will close this one. Thank you! 🍰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the FastAPI tutorial examples to use the modern
FastAPI lifespan API instead of the deprecated startup event.
The
on_startup()function is intentionally kept as a plain helperand reused by the lifespan context manager, so that existing tutorial
tests can continue to call it directly without relying on the ASGI
lifecycle.
No behavioral changes are introduced, and all tests pass.