Make .then() resolve to the server instance#114
Merged
Conversation
delvedor
reviewed
Jul 6, 2020
| t.pass('plugin2 init') | ||
| return Promise.resolve() | ||
| }).then(() => { | ||
| }).then((f2) => { |
Contributor
There was a problem hiding this comment.
The reachable pass assert is redundant now
test/await-sef.test.js
Outdated
| @@ -0,0 +1,11 @@ | |||
| 'use strict' | |||
|
|
|||
Contributor
There was a problem hiding this comment.
File name has a typo
davidmarkclements
previously requested changes
Jul 6, 2020
Contributor
davidmarkclements
left a comment
davidmarkclements
left a comment
There was a problem hiding this comment.
Overall change lgtm, just nits
delvedor
reviewed
Jul 6, 2020
test/await-sef.test.js
Outdated
| const app = {} | ||
| boot(app) | ||
|
|
||
| t.is(await app, app) |
Member
There was a problem hiding this comment.
What happens if you call await app multiple times?
Suggested change
| t.is(await app, app) | |
| t.is(await app, app) | |
| t.is(await app, app) | |
| t.is(await app, app) |
Member
Author
|
Amazing support! 👏 |
Member
Author
|
thanks! It's not normally this fast but this was a really bad one that I forgot to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes fastify/fastify#2374
Checklist
npm run testandnpm run benchmark