Skip to content

chore(types): remove deprecated debugMode option#840

Open
Tony133 wants to merge 3 commits into
mainfrom
chore/remove-debugMode-deprecated
Open

chore(types): remove deprecated debugMode option#840
Tony133 wants to merge 3 commits into
mainfrom
chore/remove-debugMode-deprecated

Conversation

@Tony133
Copy link
Copy Markdown
Member

@Tony133 Tony133 commented May 17, 2026

Proposal:

Remove the deprecated debugMode boolean option in types/index.d.ts.

Changes:

  • Removed debugMode?: boolean from types/index.d.ts
  • Update index.js
  • Update debug-mode.test.js

Note:

@Tony133 Tony133 marked this pull request as ready for review May 17, 2026 14:45
@Tony133 Tony133 requested a review from a team May 17, 2026 14:52
@mcollina
Copy link
Copy Markdown
Member

is this present in the code?

@Tony133
Copy link
Copy Markdown
Member Author

Tony133 commented May 17, 2026

@mcollina
Copy link
Copy Markdown
Member

why then this is removed from the types?

@Tony133
Copy link
Copy Markdown
Member Author

Tony133 commented May 17, 2026

why then this is removed from the types?

Sorry, I didn't finish the first commit properly. The change is now complete. See the commit here: 5c0ef6f and 229f177 I didn't run git add in the terminal 😅

Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants