Skip to content

types(index): allow undefined for some optional properties#158

Merged
Fdawgs merged 2 commits into
masterfrom
types/undefined
Jan 28, 2025
Merged

types(index): allow undefined for some optional properties#158
Fdawgs merged 2 commits into
masterfrom
types/undefined

Conversation

@Fdawgs
Copy link
Copy Markdown
Member

@Fdawgs Fdawgs commented Jan 28, 2025

This PR updates the types of some optional properties to be undefined, because they check against undefined with nullish coalescing operators and assign defaults:

const strictCredentials = opts.strictCredentials ?? true
const useUtf8 = opts.utf8 ?? true

Checklist

@Fdawgs Fdawgs merged commit 35abdb4 into master Jan 28, 2025
@Fdawgs Fdawgs deleted the types/undefined branch January 28, 2025 18:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants