Enforce pr title validation organizationwide

[Uzlopak]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the issue has not already been raised

Issue

We validate now in fastify/fastify the pr titles.

We could use a required workflow to enforce pr title validation over the whole org.

https://docs.github.com/en/actions/using-workflows/required-workflows

[Uzlopak]

Potentially interested parties:

@Fdawgs
@mcollina
@Eomm
@jsumners
@climba03003

[mcollina]

Let's wait until we do a few releases for Fastify and then decided if we want to roll it out org-wide

[jsumners]

Let's wait until we do a few releases for Fastify and then decided if we want to roll it out org-wide

This please.

[Uzlopak]

No pressure. We talked at work about required worrkflows and I thought it makes sense to create this issue to document this opportunity.

[Fdawgs]

@fastify/core, @Uzlopak since it's been 2 years how do we feel the PR title enforcement in fastify/fastify has gone?

For me it's been far easier to see what is being changed from eyeballing the PR title rather than having to hop onto the PR to suss it out.

[jsumners]

For me it's been far easier to see what is being changed from eyeballing the PR title rather than having to hop onto the PR to suss it out.

I genuinely don't see how forcing a set of prefix strings changes this. A title is still just a summary.

When I look at this list https://github.com/fastify/fastify/releases/tag/v5.5.0, or even one with far fewer changes https://github.com/fastify/fastify/releases/tag/v5.3.0, I see a difficult to read/scan mess.

[Uzlopak]

I think that it is worth to add it organization-wide.

Of course a contributor can prefix the PR title wrong. But in daily PR work it really helps. If I see a chore PR I think it will be a small PR and should be easy to grok. A fix can be small or humongous. And a feat tends to be huge. But it helps to manage the expectations.

Also it is less nagging than a commit message validation. Those really suck because you have to undo the last commit and commit again and then force push. But the title of a PR can be changed easy in the github ui.

And I changed sometimes the title to match the PR content or if the contributor didnt know that he/she should have prefix it properly. I am not nagging contributors about a "wrong" PR title by making a "Request Changes" Review. I just fix it.

That there is a difficulty to read/scan is not really an argument in the age of ctrl+f3. Also the argument is not only about the release text. But even if: if the release text is not readable, it shows, that we should consider sorting the PRs via the prefix and put the fix-PRs on top. This is what a dev is interested in, when reviewing a dependency update pr from dependabot or renovate.