Skip to content

Replace aredis with redis-py#635

Merged
wbarnha merged 7 commits into
masterfrom
remove-distutils
Nov 19, 2024
Merged

Replace aredis with redis-py#635
wbarnha merged 7 commits into
masterfrom
remove-distutils

Conversation

@wbarnha

@wbarnha wbarnha commented Jul 16, 2024

Copy link
Copy Markdown
Member

We need to get aredis out of Faust since it uses distutils, a library removed in Python 3.12.

@wbarnha wbarnha self-assigned this Jul 16, 2024
@codecov

codecov Bot commented Jul 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.09%. Comparing base (da2d10e) to head (36cd35e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
faust/web/cache/backends/redis.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
- Coverage   94.13%   94.09%   -0.05%     
==========================================
  Files         102      102              
  Lines       11093    11100       +7     
  Branches     1327     1328       +1     
==========================================
+ Hits        10442    10444       +2     
- Misses        554      557       +3     
- Partials       97       99       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Luferov

Luferov commented Jul 23, 2024

Copy link
Copy Markdown

Faust doesn't work with ardis, because aredis support by python until 3.8. Miracle, python 3.9 is working with aredis, Faust with 3.11 doesn't work. We move with aredis to redis-py 🙏

@wbarnha

wbarnha commented Jul 24, 2024

Copy link
Copy Markdown
Member Author

I'm waiting to merge this until I've tested this against an actual Redis instance.

@wbarnha wbarnha marked this pull request as ready for review November 19, 2024 02:01
@wbarnha

wbarnha commented Nov 19, 2024

Copy link
Copy Markdown
Member Author

We're going to have to get this merged if we want to support newer versions of Python.

@wbarnha wbarnha merged commit 378aede into master Nov 19, 2024
@wbarnha wbarnha deleted the remove-distutils branch November 19, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants