Update handling of artifacts in python-package.yml#649
Merged
Conversation
This will allow us to start making releases again.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 102 102
Lines 11100 11100
Branches 1328 1328
=======================================
Hits 10444 10444
Misses 557 557
Partials 99 99 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
wbarnha
added a commit
that referenced
this pull request
Jul 17, 2026
#649 bumped upload/download-artifact from v3 to v4 but kept the v3 pattern where every build_wheels matrix leg (and the sdist) uploaded under a shared artifact name and the publish job downloaded a single name. v3 merged same-named uploads; v4 does not -- each upload is its own immutable artifact and uploading the same name again fails. So the three matrix legs collide on 'wheel-artifacts', and the wheel download used pattern '*artifact*' with no path (landing outside dist/, which is what gh-action-pypi-publish publishes from). The last release (v0.11.3) predates #649 and used v3, so this is latent -- the next release would fail to publish or ship incomplete artifacts. Give each uploader a unique name (cibw-wheels-<os>, cibw-sdist), collect them all in the publish job with pattern: cibw-* + merge-multiple into dist/, add skip-existing so re-runs can backfill, and if-no-files-found: error so an empty build fails loudly instead of silently publishing nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to start making releases again.