fix: support aiokafka 0.13.0 which removed api_version parameter#674
Merged
Merged
Conversation
aiokafka 0.13.0 removed the `api_version` parameter from both `AIOKafkaConsumer` and `AIOKafkaProducer`. Since faust requires `aiokafka>=0.10.0`, it needs to handle both old and new versions. This adds a version check and conditionally includes `api_version` only when running with aiokafka < 0.13.0. Fixes faust-streaming#672
Contributor
Author
|
Gentle ping — this fixes compatibility with aiokafka 0.13.0 which removed the api_version parameter. Let me know if any changes are needed. |
Collaborator
|
Nice one thank you. |
dada-engineer
previously approved these changes
Mar 30, 2026
Collaborator
|
@Mopsgeschwindigkeit the test for 3.9 seem to fail. can you check this pls? |
patkivikram
approved these changes
Mar 30, 2026
Mopsgeschwindigkeit
pushed a commit
to smaxtec/faust
that referenced
this pull request
Mar 31, 2026
…st-streaming#674) aiokafka 0.13.0 removed the `api_version` parameter from both `AIOKafkaConsumer` and `AIOKafkaProducer`. Since faust requires `aiokafka>=0.10.0`, it needs to handle both old and new versions. This adds a version check and conditionally includes `api_version` only when running with aiokafka < 0.13.0. Fixes faust-streaming#672 Co-authored-by: nightcityblade <nightcityblade@gmail.com>
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aiokafka 0.13.0 removed the
api_versionparameter from bothAIOKafkaConsumerandAIOKafkaProducer. Since faust requiresaiokafka>=0.10.0, it needs to handle both old and new versions.This adds a version check (
_AIOKAFKA_HAS_API_VERSION) and conditionally includesapi_versionin the consumer and producer kwargs only when running with aiokafka < 0.13.0.Fixes #672
Changes
faust/transport/drivers/aiokafka.py: Added version check, conditionally passapi_versionto consumer and producertests/unit/transport/drivers/test_aiokafka.py: Updated tests to handle both aiokafka versionsTesting
All 134 tests pass (23 skipped, including 1 for the api_version parametrized test on aiokafka >= 0.13.0).