Skip to content

test(consumer): fix TransactionManager stop/start-transaction assertions #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wbarnha merged 2 commits into from
Jul 21, 2026
Merged

test(consumer): fix TransactionManager stop/start-transaction assertions #722

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b04e48d
test(consumer): fix TransactionManager stop/start-transaction assertions
wbarnha Jul 20, 2026
5456102
Merge branch 'master' into claude/reenable-transaction-tests
wbarnha Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 5 additions & 24 deletions tests/unit/transport/test_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,43 +196,24 @@ async def test_on_rebalance(self, *, manager):

await manager.on_rebalance(set(), set(), set())

@pytest.mark.skip("Needs fixing")
@pytest.mark.asyncio
async def test__stop_transactions(self, *, manager, producer):
tids = ["0-0", "1-0"]
manager._start_new_producer = AsyncMock()
await manager._stop_transactions(tids)
producer.stop_transaction.assert_called()
producer.stop_transaction.assert_called_once_with(
[
# The problem is that some reason calls with extra
# (commented out) garbage are being included
# call.shortlabel.__bool__(),
# call.shortlabel._str__(),
call("0-0"),
# call.shortlabel.__bool__(),
# call.shortlabel._str__(),
call("1-0"),
]
assert producer.stop_transaction.call_count == 2
producer.stop_transaction.assert_has_calls(
[call("0-0"), call("1-0")], any_order=True
)

@pytest.mark.skip("Needs fixing")
@pytest.mark.asyncio
async def test_start_transactions(self, *, manager, producer):
tids = ["0-0", "1-0"]
manager._start_new_producer = AsyncMock()
await manager._start_transactions(tids)
assert producer.maybe_begin_transaction.call_count == 2
producer.maybe_begin_transaction.assert_has_calls(
[
# The problem is that some reason calls with extra
# (commented out) garbage are being included
# call.shortlabel.__bool__(),
# call.shortlabel._str__(),
call("0-0"),
# call.shortlabel.__bool__(),
# call.shortlabel._str__(),
call("1-0"),
]
[call("0-0"), call("1-0")], any_order=True
)

@pytest.mark.asyncio
Expand Down
Loading