[Feature] Active status - #338
Merged
Merged
Conversation
- Fixed `onImageChange` documentation and added missing `msg` parameter - Moved `on` methods to the right place - Added changing client active status while listening - Added fetching friends' active status
madsmtm
requested changes
Sep 27, 2018
Contributor
Author
|
Yes, I saw that, this was fixed by #327 😉 |
madsmtm
requested changes
Dec 9, 2018
madsmtm
left a comment
madsmtm
left a comment
Member
There was a problem hiding this comment.
You should have a look at #260, there's some information that we're not using here yet. Maybe something in "vc" would tell us the users in_game status? And there's also information about wether a user is callable. But if you're right about #327 fixing this, then maybe we should use #273 first? And then build the buddylist caching and getUserActiveStatus on top of that?
kapi2289
force-pushed
the
active_status
branch
from
January 5, 2019 16:42
b19dc6b to
e38f891
Compare
madsmtm
requested changes
Jan 24, 2019
madsmtm
left a comment
madsmtm
left a comment
Member
There was a problem hiding this comment.
Almost there, but doOneListen is public (documented) API, so we can't change the parameter. Just deprecate it instead.
madsmtm
approved these changes
Jan 31, 2019
Member
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ActiveStatusmodelonImageChangedocumentation and added missingmsgparameteronmethods to the right place