feat: add first batch of Open edX Filters (backport) - #1
Merged
Conversation
MoisesGSalas
left a comment
MoisesGSalas
left a comment
Member
There was a problem hiding this comment.
Would you mind fixing the commit message to also include the info about the events you are adding in addition to the filters?
* Add PreEnrollmentFilter * Add PreRegisterFilter * Add PreLoginFilter For more info: openedx/openedx-platform#29449 Some events that were already on the platform were also added: * Add COURSE_ENROLLMENT_CHANGED: sent after the enrollment update * Add COURSE_ENROLLMENT_CREATED event after the user's enrollment creation * Add COURSE_UNENROLLMENT_COMPLETED: sent after the user's unenrollment For more info: openedx/openedx-platform#28266 openedx/openedx-platform#28640
MaferMazu
force-pushed
the
nau/add-filters
branch
from
August 31, 2022 00:21
5931529 to
d0ac319
Compare
Contributor
Author
|
Ready @MoisesGSalas , thanks. You can check it here: d0ac319 |
felipemontoya
approved these changes
Aug 31, 2022
felipemontoya
left a comment
felipemontoya
left a comment
Member
There was a problem hiding this comment.
This changes are correct and up to date. This PR also adds tests for the new code.
For me this is ready to proceed.
Member
|
Important note: a PR similar to this one will be required for the Maple release as well. For nutmeg this will already be present in the open-release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a Backport of the PR #29449 of the platform:
This PR is needed for FAN-41