7038 - Rulemaking Cleanup

[rfultz]

Summary

• Resolves Rulemaking Single Page Cleanup #7038

Required reviewers

• Devs
• UX?

Impacted areas of the application

The rulemakings single page

Screenshots

No visual changes 🤞🏼 (www left, 127.0.0.1 right)

Related PRs

Nah

How to test

• Pull the branch
• npm run build
• ./manage.py runserver
• Go to a rulemaking single page (I used http://127.0.0.1:8000/legal/rulemakings/2005-02/?doc_id=1229)
• Sorting/priority comes from the API, not from Jinja or views.py
• The appearance didn't change
• Semantic elements make sense (especially in the table of documents, things like <td><ul><li><a /></li></ul></td> or, worse, <td><li><a /></li></td> have been cleaned up (<td><a /></td>) so not everything is a list)
• Turn on accessibility voiceover (cmd-opt F5), check VoiceOver at the top
• Switch back to the page, click into it near the top
• Tabbing through content, the spoken content makes sense for those without visual content
• "Clicking" a PDF link with the keyboard opens the PDF in another window (instead of inside the page)
• Clicking a PDF link with the mouse still opens the PDF in the page (or tries to, security sandboxes and all)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.19%. Comparing base (aece827) to head (c843576).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7100      +/-   ##
===========================================
+ Coverage    79.02%   79.19%   +0.17%     
===========================================
  Files          255      255              
  Lines         6679     6663      -16     
===========================================
- Hits          5278     5277       -1     
+ Misses        1401     1386      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.