Skip to content

updpatch: vault 1.19.0-1#4633

Open
Cryolitia wants to merge 2 commits intofelixonmars:masterfrom
Cryolitia-Forks:valut
Open

updpatch: vault 1.19.0-1#4633
Cryolitia wants to merge 2 commits intofelixonmars:masterfrom
Cryolitia-Forks:valut

Conversation

@Cryolitia
Copy link
Contributor

Increase nodejs heap size to avoid OOM

Increase nodejs heap size to avoid OOM
@felixonmars
Copy link
Owner

Any idea why this is only needed on riscv64?

@Cryolitia
Copy link
Contributor Author

I could successfully build vault on centiskorch without the extra environment variable to increase heap limit. But we could still add it to make the build more stable.

@kxxt
Copy link
Contributor

kxxt commented Apr 7, 2025

I could successfully build vault on centiskorch without the extra environment variable to increase heap limit. But we could still add it to make the build more stable.

Then it would be more interesting to know on what kind of machibe this package encountered heap OOM.

Historically this package cannot be built on sg2042 due to OOM and changing the variable cannot fix it: #3227

Please remove it from sg2042 blacklist if it could be built on sg2042 now. Thanks.

Recently successfully built it on `centiskorch`
@Cryolitia
Copy link
Contributor Author

Then it would be more interesting to know on what kind of machibe this package encountered heap OOM.

I guess this may be related to the number of threads, but there is no evidence yet, and it is difficult to stably reproduce an OOM build.

Please remove it from sg2042 blacklist if it could be built on sg2042 now. Thanks.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants