chore(deps): bump vite-plus to 0.1.21-alpha.7#3
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the pnpm-workspace.yaml file to pin vite, vitest, and vite-plus to specific alpha versions and adds a minimumReleaseAgeExclude section. The reviewer noted that the wildcard pattern used in the exclusion list might not be supported and provided a code suggestion to explicitly list the package names and aliases to ensure the CI process functions correctly.
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - '@voidzero-dev/*' |
There was a problem hiding this comment.
The minimumReleaseAgeExclude configuration (likely used by a custom script or tool following the Vite repository's pattern) may not support wildcards like '@voidzero-dev/*'. To ensure that the alpha releases of vite and vitest (which are aliased to @voidzero-dev packages) are correctly excluded from the age check, it is safer to list the specific package names explicitly.
Additionally, depending on whether the exclusion tool checks the alias name or the resolved package name, including both the alias and the full package name is the most robust approach to prevent CI failures for these recently published alpha versions.
minimumReleaseAgeExclude:
- vite-plus
- vite
- vitest
- '@voidzero-dev/vite-plus-core'
- '@voidzero-dev/vite-plus-test'
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan