chore(deps): bump vite-plus to 0.1.21-alpha.6#1
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency to version 0.1.21-alpha.6. Feedback highlights a significant discrepancy between the pull request description and the actual code changes, noting that several intended updates to vite, vitest, and workspace configurations are missing, and required dependency aliases have not been implemented.
| "vite-plugin-electron": "0.29.1", | ||
| "vite-plugin-electron-renderer": "0.14.7", | ||
| "vite-plus": "0.1.20", | ||
| "vite-plus": "0.1.21-alpha.6", |
There was a problem hiding this comment.
The pull request description mentions updates to vite, vitest, pnpm.overrides, and pnpm-workspace.yaml, but these changes are missing from the diff. Only vite-plus is updated. Furthermore, vite and vitest are described as aliases to @voidzero-dev packages, but the package.json lacks the npm: alias syntax for these dependencies. This discrepancy between the intended changes and the actual implementation could lead to an inconsistent toolchain state.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.6.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsTest plan