Skip to content

chore(deps): bump vite-plus to 0.1.21-alpha.7#2

Draft
fengmk2 wants to merge 3 commits into
mainfrom
update-vite-plus-alpha-0.1.21-alpha.7
Draft

chore(deps): bump vite-plus to 0.1.21-alpha.7#2
fengmk2 wants to merge 3 commits into
mainfrom
update-vite-plus-alpha-0.1.21-alpha.7

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 13, 2026

Summary

Bump vite-plus and related packages to alpha 0.1.21-alpha.7.

Updated where applicable:

  • vite-plus
  • vitest (alias to @voidzero-dev/vite-plus-test)
  • vite (alias to @voidzero-dev/vite-plus-core)
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs
  • minimumReleaseAgeExclude / minimumReleaseAgeExcludes configured for pnpm + bun

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 13, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates vite-plus to version 0.1.21-alpha.7 in package.json and adds vite-plus and @voidzero-dev/* to the minimumReleaseAgeExclude list in pnpm-workspace.yaml. Feedback highlights that vitest and vite versions should be updated to maintain compatibility with the new alpha release. Additionally, there are concerns regarding discrepancies between the PR description and the implementation, specifically regarding missing catalogs, Bun compatibility, and a potential naming inconsistency for the exclusion key.

Comment thread package.json
"vite-plugin-electron": "0.29.1",
"vite-plugin-electron-renderer": "0.14.7",
"vite-plus": "0.1.20",
"vite-plus": "0.1.21-alpha.7",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description mentions that vitest and vite were updated where applicable, but they remain at their previous versions (4.1.5 and 8.0.11 respectively) in this file. Since these are aliases for @voidzero-dev/vite-plus components, they likely need to be bumped to match the new vite-plus alpha version to ensure compatibility and avoid potential build issues.

Comment thread pnpm-workspace.yaml Outdated
Comment on lines +6 to +8
minimumReleaseAgeExclude:
- vite-plus
- "@voidzero-dev/*"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are a few discrepancies regarding this configuration change:

  1. Missing Catalogs: The PR summary mentions updating pnpm-workspace.yaml catalogs, but no catalog section is present in this file, and package.json still uses hardcoded versions instead of the catalog: protocol.
  2. Bun Compatibility: The summary mentions this is configured for pnpm + bun, but Bun does not typically read configuration from pnpm-workspace.yaml. This setting might need to be duplicated in a Bun-compatible configuration file (e.g., bunfig.toml).
  3. Naming Consistency: The summary uses both minimumReleaseAgeExclude and minimumReleaseAgeExcludes. If the tool enforcing this policy expects the plural form for a list, the current singular key might be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant