chore(deps): bump vite-plus to 0.1.21-alpha.7#2
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates vite-plus to version 0.1.21-alpha.7 in package.json and adds vite-plus and @voidzero-dev/* to the minimumReleaseAgeExclude list in pnpm-workspace.yaml. Feedback highlights that vitest and vite versions should be updated to maintain compatibility with the new alpha release. Additionally, there are concerns regarding discrepancies between the PR description and the implementation, specifically regarding missing catalogs, Bun compatibility, and a potential naming inconsistency for the exclusion key.
| "vite-plugin-electron": "0.29.1", | ||
| "vite-plugin-electron-renderer": "0.14.7", | ||
| "vite-plus": "0.1.20", | ||
| "vite-plus": "0.1.21-alpha.7", |
There was a problem hiding this comment.
The pull request description mentions that vitest and vite were updated where applicable, but they remain at their previous versions (4.1.5 and 8.0.11 respectively) in this file. Since these are aliases for @voidzero-dev/vite-plus components, they likely need to be bumped to match the new vite-plus alpha version to ensure compatibility and avoid potential build issues.
| minimumReleaseAgeExclude: | ||
| - vite-plus | ||
| - "@voidzero-dev/*" |
There was a problem hiding this comment.
There are a few discrepancies regarding this configuration change:
- Missing Catalogs: The PR summary mentions updating
pnpm-workspace.yamlcatalogs, but nocatalogsection is present in this file, andpackage.jsonstill uses hardcoded versions instead of thecatalog:protocol. - Bun Compatibility: The summary mentions this is configured for pnpm + bun, but Bun does not typically read configuration from
pnpm-workspace.yaml. This setting might need to be duplicated in a Bun-compatible configuration file (e.g.,bunfig.toml). - Naming Consistency: The summary uses both
minimumReleaseAgeExcludeandminimumReleaseAgeExcludes. If the tool enforcing this policy expects the plural form for a list, the current singular key might be ignored.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan