chore(deps): bump vite-plus to 0.1.21-alpha.6#3
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vite-plus dependency and the resolutions for vite and vitest to version 0.1.21-alpha.6. Feedback suggests improving the clarity of the vitest dependency by using the npm: protocol directly in devDependencies rather than overriding it via resolutions, which is more idiomatic for Yarn 4.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.6", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.6" |
There was a problem hiding this comment.
The resolutions for vite and vitest have been updated to a specific alpha version, which is a good practice for reproducibility. However, vitest is also listed as a direct dependency in devDependencies (line 41) with version ^4.1.4.
In Yarn 4, when aliasing a direct dependency to another package (like @voidzero-dev/vite-plus-test), it is more idiomatic and clearer to use the npm: protocol directly in the devDependencies entry. This avoids the confusion of having a misleading version string (^4.1.4) that is immediately overridden by a resolution.
Consider updating the devDependencies entry for vitest to use the alias directly and removing it from resolutions if it's not needed for transitive dependencies.
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.6.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsTest plan