Skip to content

chore(deps): bump vite-plus to 0.1.21-alpha.6#3

Draft
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-alpha-0.1.21-alpha.6
Draft

chore(deps): bump vite-plus to 0.1.21-alpha.6#3
fengmk2 wants to merge 2 commits into
mainfrom
update-vite-plus-alpha-0.1.21-alpha.6

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 12, 2026

Summary

Bump vite-plus and related packages to alpha 0.1.21-alpha.6.

Updated where applicable:

  • vite-plus
  • vitest (alias to @voidzero-dev/vite-plus-test)
  • vite (alias to @voidzero-dev/vite-plus-core)
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 12, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vite-plus dependency and the resolutions for vite and vitest to version 0.1.21-alpha.6. Feedback suggests improving the clarity of the vitest dependency by using the npm: protocol directly in devDependencies rather than overriding it via resolutions, which is more idiomatic for Yarn 4.

Comment thread package.json
Comment on lines +44 to +45
"vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.6",
"vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.6"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The resolutions for vite and vitest have been updated to a specific alpha version, which is a good practice for reproducibility. However, vitest is also listed as a direct dependency in devDependencies (line 41) with version ^4.1.4.

In Yarn 4, when aliasing a direct dependency to another package (like @voidzero-dev/vite-plus-test), it is more idiomatic and clearer to use the npm: protocol directly in the devDependencies entry. This avoids the confusion of having a misleading version string (^4.1.4) that is immediately overridden by a resolution.

Consider updating the devDependencies entry for vitest to use the alias directly and removing it from resolutions if it's not needed for transitive dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant