chore(deps): bump vite-plus to 0.1.21-alpha.7#4
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the versions of vite, vite-plus, and vitest to a specific alpha release (0.1.21-alpha.7) within the Yarn catalog and package.json. The reviewer recommends utilizing the Yarn 4 catalog: protocol in the package.json dependencies and resolutions block to centralize version management and improve maintainability.
| "prettier": "^3.8.3", | ||
| "typescript": "^6.0.3", | ||
| "vite-plus": "^0.1.18", | ||
| "vite-plus": "0.1.21-alpha.7", |
There was a problem hiding this comment.
Since you have defined vite-plus in the Yarn 4 catalog within .yarnrc.yml, you should use the catalog: protocol here. This centralizes version management and ensures consistency across the workspace. Additionally, consider updating the vitest dependency on line 41 to use the catalog as well, as the current version (^4.1.4) appears inconsistent with the alpha versioning scheme.
| "vite-plus": "0.1.21-alpha.7", | |
| "vite-plus": "catalog:", |
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | ||
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" |
There was a problem hiding this comment.
The resolutions block can also leverage the catalog entries. This avoids duplicating the npm: alias and version string, making the configuration more maintainable.
| "vite": "npm:@voidzero-dev/vite-plus-core@0.1.21-alpha.7", | |
| "vitest": "npm:@voidzero-dev/vite-plus-test@0.1.21-alpha.7" | |
| "vite": "catalog:", | |
| "vitest": "catalog:" |
Summary
Bump
vite-plusand related packages to alpha 0.1.21-alpha.7.Updated where applicable:
vite-plusvitest(alias to@voidzero-dev/vite-plus-test)vite(alias to@voidzero-dev/vite-plus-core)overrides/resolutions/pnpm.overrides/pnpm-workspace.yamlcatalogsminimumReleaseAgeExclude/minimumReleaseAgeExcludesconfigured for pnpm + bunTest plan