Skip to content

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5

Draft
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633
Draft

chore(deps): bump vite-plus to PR #1633 (pkg-pr-new)#5
fengmk2 wants to merge 1 commit into
mainfrom
update-vite-plus-prerelease-test-pr-1633

Conversation

@fengmk2
Copy link
Copy Markdown
Owner

@fengmk2 fengmk2 commented May 19, 2026

Summary

Bump vite-plus and related @voidzero-dev/* packages to the pkg-pr-new prerelease for vite-plus PR #1633.

Updated where applicable:

  • vite-plushttps://pkg.pr.new/voidzero-dev/vite-plus@1633
  • vite alias → @voidzero-dev/vite-plus-core pkg-pr-new URL
  • vitest alias → @voidzero-dev/vite-plus-test pkg-pr-new URL
  • overrides / resolutions / pnpm.overrides / pnpm-workspace.yaml catalogs

Also configured minimum-release-age with vite-plus / @voidzero-dev/* excluded for pnpm / bun / npm.

Test plan

  • CI passes

@fengmk2 fengmk2 self-assigned this May 19, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request transitions several core dependencies, including vite, vite-plus, and vitest, from npm registry versions to preview builds hosted on pkg.pr.new. It also updates various oxc and oxlint related packages and introduces unrun as an optional dependency. Feedback focused on the risk of non-reproducible builds caused by using PR-based URLs instead of pinned commit hashes. The reviewer suggested utilizing the Yarn catalog: protocol to improve maintainability and ensure dependency stability.

Comment thread package.json
"prettier": "^3.8.3",
"typescript": "^6.0.3",
"vite-plus": "^0.1.18",
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Critical Issue: Non-Reproducible Builds

The current yarn.lock file contains unresolved pkg.pr.new URLs with PR numbers (e.g., @1633) instead of being pinned to specific commit hashes. This can lead to non-reproducible builds, as the dependency can change if new commits are pushed to the PR branch.

To fix this and improve maintainability, it's recommended to use the catalog: protocol for dependencies defined in your .yarnrc.yml catalog. This is the idiomatic approach for Yarn Berry and can help ensure dependencies are correctly resolved and pinned.

Suggested change
"vite-plus": "https://pkg.pr.new/voidzero-dev/vite-plus@1633",
"vite-plus": "catalog:vite-plus",

Comment thread package.json
Comment on lines +45 to +46
"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

High Severity: Non-Reproducible Builds in Resolutions

The resolutions field also uses URLs with PR numbers, which can lead to non-reproducible builds for the same reason mentioned in the comment on vite-plus. Since you are using Yarn Berry and have a catalog defined in .yarnrc.yml, you can leverage it here as well.

Using the catalog: protocol avoids duplicating URLs and should help in correctly pinning the vitest dependency to a commit hash in yarn.lock.

Suggested change
"vite": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-core@1633",
"vitest": "https://pkg.pr.new/voidzero-dev/vite-plus/@voidzero-dev/vite-plus-test@1633"
"vite": "catalog:vite",
"vitest": "catalog:vitest"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant